Checkstyle Results

The following document contains the results of Checkstyle 9.3 with sun_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
25 0 0 155

Files

File  I  W  E
de/aikiit/bilanzanalyser/WebAppApplication.java 0 0 3
de/aikiit/bilanzanalyser/analyse/AnalyseController.java 0 0 5
de/aikiit/bilanzanalyser/analyse/AnalyseService.java 0 0 1
de/aikiit/bilanzanalyser/api/DataController.java 0 0 14
de/aikiit/bilanzanalyser/api/DataItem.java 0 0 2
de/aikiit/bilanzanalyser/entity/BilanzRow.java 0 0 8
de/aikiit/bilanzanalyser/entity/database/BilanzRowEntity.java 0 0 8
de/aikiit/bilanzanalyser/entity/database/CategoryEntity.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/DataInitializer.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/PaymentEntity.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/ShopEntity.java 0 0 3
de/aikiit/bilanzanalyser/entity/database/SourceEntity.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/repository/BilanzRowRepository.java 0 0 4
de/aikiit/bilanzanalyser/entity/database/repository/CategoryRepository.java 0 0 3
de/aikiit/bilanzanalyser/entity/database/repository/PaymentRepository.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/repository/ShopRepository.java 0 0 2
de/aikiit/bilanzanalyser/entity/database/repository/SourceRepository.java 0 0 3
de/aikiit/bilanzanalyser/reader/BilanzOdsReader.java 0 0 9
de/aikiit/bilanzanalyser/reader/BilanzRowParser.java 0 0 15
de/aikiit/bilanzanalyser/reader/BilanzRowParserResult.java 0 0 4
de/aikiit/bilanzanalyser/reader/BilanzRowParserStatistic.java 0 0 3
de/aikiit/bilanzanalyser/upload/SourceService.java 0 0 3
de/aikiit/bilanzanalyser/upload/UploadAnalysisService.java 0 0 37
de/aikiit/bilanzanalyser/upload/UploadController.java 0 0 18

Rules

Category Rule Violations Severity
coding HiddenField 14  Error
MagicNumber 8  Error
design DesignForExtension 7  Error
HideUtilityClassConstructor 2  Error
imports UnusedImports
  • processJavadoc: "false"
1  Error
javadoc JavadocPackage 8  Error
JavadocStyle 1  Error
JavadocVariable 41  Error
MissingJavadocMethod 20  Error
misc NewlineAtEndOfFile 6  Error
sizes LineLength
  • fileExtensions: "java"
47  Error

Details

de/aikiit/bilanzanalyser/WebAppApplication.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 7
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 10

de/aikiit/bilanzanalyser/analyse/AnalyseController.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 16
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 18
 Error coding HiddenField 'categoryRepository' hides a field. 18
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 22
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 29

de/aikiit/bilanzanalyser/analyse/AnalyseService.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1

de/aikiit/bilanzanalyser/api/DataController.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 18
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error sizes LineLength Line is longer than 80 characters (found 240). 23
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 23
 Error coding HiddenField 'bilanzRowRepository' hides a field. 23
 Error coding HiddenField 'categoryRepository' hides a field. 23
 Error coding HiddenField 'paymentRepository' hides a field. 23
 Error coding HiddenField 'shopRepository' hides a field. 23
 Error coding HiddenField 'sourceRepository' hides a field. 23
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 31
 Error sizes LineLength Line is longer than 80 characters (found 83). 33

de/aikiit/bilanzanalyser/api/DataItem.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1

de/aikiit/bilanzanalyser/entity/BilanzRow.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error javadoc JavadocVariable Missing a Javadoc comment. 22
 Error javadoc JavadocVariable Missing a Javadoc comment. 23
 Error javadoc JavadocVariable Missing a Javadoc comment. 24

de/aikiit/bilanzanalyser/entity/database/BilanzRowEntity.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 16
 Error javadoc JavadocVariable Missing a Javadoc comment. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error javadoc JavadocVariable Missing a Javadoc comment. 22
 Error javadoc JavadocVariable Missing a Javadoc comment. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error javadoc JavadocVariable Missing a Javadoc comment. 30

de/aikiit/bilanzanalyser/entity/database/CategoryEntity.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 19

de/aikiit/bilanzanalyser/entity/database/DataInitializer.java

Severity Category Rule Message Line
 Error design DesignForExtension Class 'DataInitializer' looks like designed for extension (can be subclassed), but the method 'initData' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DataInitializer' final or making the method 'initData' static/final/abstract/empty, or adding allowed annotation for the method. 14
 Error sizes LineLength Line is longer than 80 characters (found 116). 15

de/aikiit/bilanzanalyser/entity/database/PaymentEntity.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 19

de/aikiit/bilanzanalyser/entity/database/ShopEntity.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 19

de/aikiit/bilanzanalyser/entity/database/SourceEntity.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 19

de/aikiit/bilanzanalyser/entity/database/repository/BilanzRowRepository.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error sizes LineLength Line is longer than 80 characters (found 83). 6
 Error sizes LineLength Line is longer than 80 characters (found 96). 9

de/aikiit/bilanzanalyser/entity/database/repository/CategoryRepository.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error sizes LineLength Line is longer than 80 characters (found 81). 8
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 10

de/aikiit/bilanzanalyser/entity/database/repository/PaymentRepository.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 10

de/aikiit/bilanzanalyser/entity/database/repository/ShopRepository.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 10

de/aikiit/bilanzanalyser/entity/database/repository/SourceRepository.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 12
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 14

de/aikiit/bilanzanalyser/reader/BilanzOdsReader.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - java.io.File. 12
 Error javadoc JavadocVariable Missing a Javadoc comment. 27
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error sizes LineLength Line is longer than 80 characters (found 109). 34
 Error sizes LineLength Line is longer than 80 characters (found 90). 46
 Error coding MagicNumber '5' is a magic number. 57
 Error sizes LineLength Line is longer than 80 characters (found 122). 58
 Error sizes LineLength Line is longer than 80 characters (found 141). 81
 Error sizes LineLength Line is longer than 80 characters (found 102). 89

de/aikiit/bilanzanalyser/reader/BilanzRowParser.java

Severity Category Rule Message Line
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 16
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 20
 Error sizes LineLength Line is longer than 80 characters (found 142). 22
 Error sizes LineLength Line is longer than 80 characters (found 84). 23
 Error sizes LineLength Line is longer than 80 characters (found 88). 28
 Error sizes LineLength Line is longer than 80 characters (found 94). 30
 Error coding MagicNumber '3' is a magic number. 39
 Error coding MagicNumber '4' is a magic number. 40
 Error coding MagicNumber '5' is a magic number. 41
 Error sizes LineLength Line is longer than 80 characters (found 91). 51
 Error sizes LineLength Line is longer than 80 characters (found 306). 60
 Error coding MagicNumber '3' is a magic number. 60
 Error coding MagicNumber '4' is a magic number. 60
 Error coding MagicNumber '5' is a magic number. 60
 Error sizes LineLength Line is longer than 80 characters (found 81). 64

de/aikiit/bilanzanalyser/reader/BilanzRowParserResult.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 7
 Error sizes LineLength Line is longer than 80 characters (found 89). 14
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 16
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 20

de/aikiit/bilanzanalyser/reader/BilanzRowParserStatistic.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error sizes LineLength Line is longer than 80 characters (found 85). 10
 Error sizes LineLength Line is longer than 80 characters (found 106). 11

de/aikiit/bilanzanalyser/upload/SourceService.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 11
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 13
 Error coding HiddenField 'sourceRepository' hides a field. 13

de/aikiit/bilanzanalyser/upload/UploadAnalysisService.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error javadoc JavadocVariable Missing a Javadoc comment. 30
 Error javadoc JavadocVariable Missing a Javadoc comment. 31
 Error javadoc JavadocVariable Missing a Javadoc comment. 32
 Error javadoc JavadocVariable Missing a Javadoc comment. 33
 Error javadoc JavadocVariable Missing a Javadoc comment. 34
 Error sizes LineLength Line is longer than 80 characters (found 247). 36
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 36
 Error coding HiddenField 'bilanzRowRepository' hides a field. 36
 Error coding HiddenField 'shopRepository' hides a field. 36
 Error coding HiddenField 'paymentRepository' hides a field. 36
 Error coding HiddenField 'categoryRepository' hides a field. 36
 Error coding HiddenField 'sourceRepository' hides a field. 36
 Error sizes LineLength Line is longer than 80 characters (found 110). 52
 Error sizes LineLength Line is longer than 80 characters (found 81). 53
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'flushDataIntoDatabase' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'flushDataIntoDatabase' static/final/abstract/empty, or adding allowed annotation for the method. 57
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 57
 Error sizes LineLength Line is longer than 80 characters (found 111). 75
 Error coding MagicNumber '1_000_000' is a magic number. 75
 Error sizes LineLength Line is longer than 80 characters (found 83). 79
 Error sizes LineLength Line is longer than 80 characters (found 111). 80
 Error sizes LineLength Line is longer than 80 characters (found 88). 82
 Error sizes LineLength Line is longer than 80 characters (found 86). 83
 Error sizes LineLength Line is longer than 80 characters (found 91). 84
 Error sizes LineLength Line is longer than 80 characters (found 84). 86
 Error sizes LineLength Line is longer than 80 characters (found 93). 87
 Error sizes LineLength Line is longer than 80 characters (found 99). 88
 Error sizes LineLength Line is longer than 80 characters (found 101). 90
 Error sizes LineLength Line is longer than 80 characters (found 84). 93
 Error sizes LineLength Line is longer than 80 characters (found 94). 94
 Error sizes LineLength Line is longer than 80 characters (found 83). 97
 Error sizes LineLength Line is longer than 80 characters (found 124). 100
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateShop' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateShop' static/final/abstract/empty, or adding allowed annotation for the method. 113
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreatePayment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreatePayment' static/final/abstract/empty, or adding allowed annotation for the method. 122
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateCategory' static/final/abstract/empty, or adding allowed annotation for the method. 131
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateSource' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateSource' static/final/abstract/empty, or adding allowed annotation for the method. 140
 Error design DesignForExtension Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'replaceIfEmpty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'replaceIfEmpty' static/final/abstract/empty, or adding allowed annotation for the method. 149

de/aikiit/bilanzanalyser/upload/UploadController.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 27
 Error javadoc JavadocVariable Missing a Javadoc comment. 29
 Error sizes LineLength Line is longer than 80 characters (found 115). 32
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 32
 Error coding HiddenField 'uploadAnalysisService' hides a field. 32
 Error coding HiddenField 'sourceService' hides a field. 32
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 37
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 45
 Error sizes LineLength Line is longer than 80 characters (found 157). 46
 Error sizes LineLength Line is longer than 80 characters (found 91). 52
 Error sizes LineLength Line is longer than 80 characters (found 82). 57
 Error sizes LineLength Line is longer than 80 characters (found 94). 65
 Error sizes LineLength Line is longer than 80 characters (found 82). 72
 Error sizes LineLength Line is longer than 80 characters (found 100). 76
 Error sizes LineLength Line is longer than 80 characters (found 109). 80
 Error sizes LineLength Line is longer than 80 characters (found 149). 85