Checkstyle Results
The following document contains the results of Checkstyle 9.3 with sun_checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 24 | 0 | 0 | 189 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | HiddenField | 13 | Error |
| MagicNumber | 9 | Error | |
| design | DesignForExtension | 7 | Error |
| HideUtilityClassConstructor | 2 | Error | |
| imports | UnusedImports
|
1 | Error |
| javadoc | JavadocPackage | 8 | Error |
| JavadocStyle | 1 | Error | |
| JavadocVariable | 40 | Error | |
| MissingJavadocMethod | 19 | Error | |
| misc | FinalParameters | 33 | Error |
| NewlineAtEndOfFile | 10 | Error | |
| sizes | LineLength
|
46 | Error |
Details
application.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
de/aikiit/bilanzanalyser/WebAppApplication.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 7 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Error |
misc | FinalParameters | Parameter args should be final. | 10 |
de/aikiit/bilanzanalyser/analyse/AnalyseController.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
de/aikiit/bilanzanalyser/api/DataController.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 210). | 23 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
| Error |
misc | FinalParameters | Parameter bilanzRowRepository should be final. | 23 |
| Error |
coding | HiddenField | 'bilanzRowRepository' hides a field. | 23 |
| Error |
misc | FinalParameters | Parameter categoryRepository should be final. | 23 |
| Error |
coding | HiddenField | 'categoryRepository' hides a field. | 23 |
| Error |
misc | FinalParameters | Parameter paymentRepository should be final. | 23 |
| Error |
coding | HiddenField | 'paymentRepository' hides a field. | 23 |
| Error |
misc | FinalParameters | Parameter shopRepository should be final. | 23 |
| Error |
coding | HiddenField | 'shopRepository' hides a field. | 23 |
| Error |
misc | FinalParameters | Parameter sourceRepository should be final. | 23 |
| Error |
coding | HiddenField | 'sourceRepository' hides a field. | 23 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 33 |
de/aikiit/bilanzanalyser/api/DataItem.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
de/aikiit/bilanzanalyser/entity/BilanzRow.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
de/aikiit/bilanzanalyser/entity/database/BilanzRowEntity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
de/aikiit/bilanzanalyser/entity/database/CategoryEntity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
de/aikiit/bilanzanalyser/entity/database/DataInitializer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
design | DesignForExtension | Class 'DataInitializer' looks like designed for extension (can be subclassed), but the method 'initData' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DataInitializer' final or making the method 'initData' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 104). | 15 |
| Error |
misc | FinalParameters | Parameter paymentRepository should be final. | 15 |
| Error |
misc | FinalParameters | Parameter sourceRepository should be final. | 15 |
de/aikiit/bilanzanalyser/entity/database/PaymentEntity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
de/aikiit/bilanzanalyser/entity/database/ShopEntity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
de/aikiit/bilanzanalyser/entity/database/SourceEntity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
de/aikiit/bilanzanalyser/entity/database/repository/BilanzRowRepository.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 6 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 96). | 9 |
de/aikiit/bilanzanalyser/entity/database/repository/CategoryRepository.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 8 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
de/aikiit/bilanzanalyser/entity/database/repository/PaymentRepository.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
de/aikiit/bilanzanalyser/entity/database/repository/ShopRepository.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
de/aikiit/bilanzanalyser/entity/database/repository/SourceRepository.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
de/aikiit/bilanzanalyser/reader/BilanzOdsReader.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 115). | 31 |
| Error |
coding | MagicNumber | '10' is a magic number. | 35 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 109). | 52 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 90). | 64 |
| Error |
coding | MagicNumber | '5' is a magic number. | 75 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 122). | 76 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 141). | 99 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 102). | 107 |
de/aikiit/bilanzanalyser/reader/BilanzRowParser.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | UnusedImports | Unused import - java.text.NumberFormat. | 12 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 17 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 142). | 23 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 84). | 24 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 126). | 31 |
| Error |
coding | MagicNumber | '3' is a magic number. | 33 |
| Error |
coding | MagicNumber | '4' is a magic number. | 34 |
| Error |
coding | MagicNumber | '5' is a magic number. | 35 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 91). | 45 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 306). | 54 |
| Error |
coding | MagicNumber | '3' is a magic number. | 54 |
| Error |
coding | MagicNumber | '4' is a magic number. | 54 |
| Error |
coding | MagicNumber | '5' is a magic number. | 54 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 59 |
| Error |
misc | FinalParameters | Parameter amount should be final. | 64 |
de/aikiit/bilanzanalyser/reader/BilanzRowParserResult.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 7 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 89). | 14 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
misc | FinalParameters | Parameter newRows should be final. | 57 |
| Error |
misc | FinalParameters | Parameter row should be final. | 67 |
de/aikiit/bilanzanalyser/reader/BilanzRowParserStatistic.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | FinalParameters | Parameter result should be final. | 10 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 106). | 11 |
de/aikiit/bilanzanalyser/upload/SourceService.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Error |
misc | FinalParameters | Parameter sourceRepository should be final. | 13 |
| Error |
coding | HiddenField | 'sourceRepository' hides a field. | 13 |
de/aikiit/bilanzanalyser/upload/UploadAnalysisService.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 217). | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
misc | FinalParameters | Parameter bilanzRowRepository should be final. | 36 |
| Error |
coding | HiddenField | 'bilanzRowRepository' hides a field. | 36 |
| Error |
misc | FinalParameters | Parameter shopRepository should be final. | 36 |
| Error |
coding | HiddenField | 'shopRepository' hides a field. | 36 |
| Error |
misc | FinalParameters | Parameter paymentRepository should be final. | 36 |
| Error |
coding | HiddenField | 'paymentRepository' hides a field. | 36 |
| Error |
misc | FinalParameters | Parameter categoryRepository should be final. | 36 |
| Error |
coding | HiddenField | 'categoryRepository' hides a field. | 36 |
| Error |
misc | FinalParameters | Parameter sourceRepository should be final. | 36 |
| Error |
coding | HiddenField | 'sourceRepository' hides a field. | 36 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 98). | 52 |
| Error |
misc | FinalParameters | Parameter worksheetName should be final. | 52 |
| Error |
misc | FinalParameters | Parameter spreadsheet should be final. | 52 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 53 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'flushDataIntoDatabase' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'flushDataIntoDatabase' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
| Error |
misc | FinalParameters | Parameter data should be final. | 58 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 111). | 74 |
| Error |
coding | MagicNumber | '1_000_000' is a magic number. | 74 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 78 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 111). | 79 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 88). | 81 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 86). | 82 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 91). | 83 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 84). | 85 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 93). | 86 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 99). | 87 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 101). | 89 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 84). | 92 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 94). | 93 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 96 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 106). | 99 |
| Error |
misc | FinalParameters | Parameter rawName should be final. | 99 |
| Error |
misc | FinalParameters | Parameter finder should be final. | 99 |
| Error |
misc | FinalParameters | Parameter creator should be final. | 99 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateShop' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateShop' static/final/abstract/empty, or adding allowed annotation for the method. | 112 |
| Error |
misc | FinalParameters | Parameter name should be final. | 113 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreatePayment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreatePayment' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
| Error |
misc | FinalParameters | Parameter name should be final. | 122 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 130 |
| Error |
misc | FinalParameters | Parameter name should be final. | 131 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'getOrCreateSource' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'getOrCreateSource' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
| Error |
misc | FinalParameters | Parameter name should be final. | 140 |
| Error |
design | DesignForExtension | Class 'UploadAnalysisService' looks like designed for extension (can be subclassed), but the method 'replaceIfEmpty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UploadAnalysisService' final or making the method 'replaceIfEmpty' static/final/abstract/empty, or adding allowed annotation for the method. | 148 |
| Error |
misc | FinalParameters | Parameter value should be final. | 148 |
de/aikiit/bilanzanalyser/upload/UploadController.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 103). | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
| Error |
misc | FinalParameters | Parameter uploadAnalysisService should be final. | 32 |
| Error |
coding | HiddenField | 'uploadAnalysisService' hides a field. | 32 |
| Error |
misc | FinalParameters | Parameter sourceService should be final. | 32 |
| Error |
coding | HiddenField | 'sourceService' hides a field. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 145). | 46 |
| Error |
misc | FinalParameters | Parameter file should be final. | 46 |
| Error |
misc | FinalParameters | Parameter selectedWorksheet should be final. | 46 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 91). | 52 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 82). | 57 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 94). | 65 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 82). | 72 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 100). | 76 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 109). | 80 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 149). | 85 |